Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add previewFileMimeTypes to defaultconfig.go #4414

Merged
merged 4 commits into from
Aug 26, 2022
Merged

Add previewFileMimeTypes to defaultconfig.go #4414

merged 4 commits into from
Aug 26, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Aug 18, 2022 •
edited
Loading

Description

Enhancement: Add previewFileMimeTypes to web default config

We've added previewFileMimeTypes to the web default config, so web can determine which preview types are supported
by the backend.

Related Issue

  • Fixes <issue_link>

Motivation and Context

Part of: owncloud/web#7474

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Aug 18, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear marked this pull request as ready for review August 18, 2022 11:45
@ownclouders
Copy link
Contributor

💥 Acceptance test Core-API-Tests-ocis-storage-3 failed. Further test are cancelled...

@sonarcloud
Copy link

sonarcloud bot commented Aug 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit a999dd1 into master Aug 26, 2022
@delete-merged-branch delete-merged-branch bot deleted the web-config-previewFileMimeTypes branch August 26, 2022 09:51
ownclouders pushed a commit that referenced this pull request Aug 26, 2022
commit a999dd1
b80500c 
Author: Jan <j.ackermann91@gmail.com>
Date:   Fri Aug 26 11:51:33 2022 +0200

    Add previewFileMimeTypes to defaultconfig.go (#4414)

    * Add previewFileMimeTypes to defaultconfig.go

    * Add changelog item

    * Format

    * Remove obsolete hideSearchBar config setting
@micbar micbar mentioned this pull request Sep 12, 2022
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic Awaiting requested review from butonic

@kulmann kulmann Awaiting requested review from kulmann kulmann is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexAndBear @ownclouders @kulmann